Lack of properties

[Abizern]

I've just been writing an example project (soon to appear!) using ObjectiveGit.

There seems to be a lack of properties for a lot of the objects. And many manually created KVC type setters that take an NSError** parameter.

That meant that I had to do more work than I needed to to set up Bindings for the UI.

Before I undertake a large refactor of this , is there any reason why properties have been avoided?

[joshaber]

We thought about creating @property wrappers around the error: accessors, but I'm not sure we want to encourage people to ignore the errors.

[Abizern]

I think this would still work if we declared readonly properties, which will give the benefits of KVO (and bindings on the desktop) and still set the backing values with the methods that take an NSError * reference. If you look at the example project I made to demonstrate how to add the framework to a project, I had to do some fiddling in the controller layer to expose commit properties that would have been better off exposed arrt the model layer.

But, rather than talk about it, I'll just make some changes and try and persuade you to pull my changes. That is the Open Source Way, isn't it ;)

[joshaber]

Sounds good, I'll wait for the PR :)