Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to new release #288

Merged
merged 3 commits into from Nov 20, 2013

Conversation

Projects
None yet
3 participants
@carlosmn
Copy link
Member

carlosmn commented Nov 20, 2013

Adjust to the changes in 0.20. This includes moving away from callback to iterations, letting us do better error reporting.

carlosmn added some commits Oct 30, 2013

Adjust to libgit2 development branch
This wraps the previous functionality, though there are some iterator
changes we might still want to bring over.
@carlosmn

This comment has been minimized.

Copy link
Member Author

carlosmn commented Nov 20, 2013

While doing this update, I noticed that pygit2 returns a tuple when asked for the references in a repo. It seems really odd to me to return a tuple rather than a list, as you don't know how many there are beforehand, and they're not sorted (and sorting wouldn't have any meaning you could put into a tuple anyway). Is there some deeper pythonic reason for this?

@jdavid jdavid merged commit 4c47eba into libgit2:master Nov 20, 2013

1 check passed

default The Travis CI build passed
Details
@jdavid

This comment has been minimized.

Copy link
Member

jdavid commented Nov 20, 2013

You're right, it would be more correct, pythonic, to return a list.

The Python criteria is, if it is a sequence of semantically the same kind of object, then it is a list. If it is a package of different kind of objects, like a record, then it is a tuple.

@alexband

This comment has been minimized.

Copy link

alexband commented on b7e906e Dec 12, 2013

hi @carlosmn is git_diff_list depreciated in libgit2, we here has a kind of fork of pygi2 with some modification. The fork hasn't sync with the main repo for a while, and now there are some conflicts with git_diff_list, I found your commit to adjust to libgit2, is there any explanation or documentation about the git_diff_list thing, either in libgit2 or pygit2. Thanks in advance.

This comment has been minimized.

Copy link

alexband replied Dec 12, 2013

seems that it's just rename libgit2/libgit2@3ff1d12

so I can just rename it , cool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.