Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/install.rst: added pkg-config as a dependency for building libgit2. #497

Merged
merged 2 commits into from Mar 8, 2015

Conversation

kitsemets
Copy link
Contributor

Without pkg-config it is not possible to build libgit2 with ssh support.
In libgit2/CMakeLists.txt the detection of libssh2library is done with PKG_CHECK_MODULES:

IF (USE_SSH)
        PKG_CHECK_MODULES(LIBSSH2 libssh2)
ENDIF()
IF (LIBSSH2_FOUND)
        ADD_DEFINITIONS(-DGIT_SSH)
        INCLUDE_DIRECTORIES(${LIBSSH2_INCLUDE_DIRS})
        LINK_DIRECTORIES(${LIBSSH2_LIBRARY_DIRS})
        SET(LIBGIT2_PC_REQUIRES "${LIBGIT2_PC_REQUIRES} libssh2")
        SET(SSH_LIBRARIES ${LIBSSH2_LIBRARIES})
ELSE()
        MESSAGE(STATUS "LIBSSH2 not found. Set CMAKE_PREFIX_PATH if it is installed outside of the default search path.")
ENDIF()

If pkg-config package does not exist, it'll continue without adding libssh2 support.

…t2. Without pkg-config it is not possible to build libgit2 with ssh support.
@carlosmn
Copy link
Member

carlosmn commented Mar 2, 2015

pkg-config is also an optional dependency, as libgit2 builds just fine without it.

@jdavid
Copy link
Member

jdavid commented Mar 6, 2015

So it should be clearly stated that pkg-config is only required for SSH support, just like the libssh2 dependency above.

@jdavid jdavid merged commit 2d3f9d8 into libgit2:master Mar 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants