Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added last update date next to api version #7

Closed
wants to merge 1 commit into from

Conversation

jsalamander
Copy link

EVO-403

@jsalamander
Copy link
Author

@hairmare any idea why the travis check failed?

@hairmare
Copy link

It always does... I've started a more sane approach in http://swagger-browser-develop.nova.scapp.io/ but haven't finished the integration in local deploys yet for that...

Could you also point me in the direction of the code that is writing the info.lastUpdate field? I'd like to see where that's coming from... AFAIK it's not in the swagger spec?

@hairmare
Copy link

Also, I can't seem to see this reflected in the EVO 403 story... Found it and even wrote it myself ;) Still, we should call the property x-lastUpdate so the swagger we generate is still valid.

I think we should first check if the swagger.io validates the swagger with this change before changing this in our swagger-ui fork.

@jsalamander
Copy link
Author

It's related to this PR.
The "last update" field is generated when running swagger:generate so the swagger-ui fetches the date from swagger.json.
See here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants