Hotfix recalc_primer_sec_struct missing thal_result.sec_struct initialization to NULL
#112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
initialization to `NULL` in `recalc_primer_sec_struct` in `libprimer3.c` and `libprimer3flex.c`. `CHANGES` updated
benpruitt
approved these changes
May 31, 2023
grinner
added a commit
that referenced
this pull request
May 31, 2023
* migrated primer3 header file Cython extern imports to `thermoanalysis.pxi` (#100) Optional C structure string argument `c_ascii_structure` added to `_ThermoAnalysis` methods to enable 3rd party use for structures version bump to 2.0.0a1 due to breaking change * fix for issue 108 whereby no_structure is not correctly 1 set to 1 when no secondary structure in found (#109) * Issue 50 update to add list version of (#110) PRIMER_{PAIR, LEFT, RIGHT, INTERNAL} output dictionary keys. Retaining original keys as well for compatibility version bump to 2.0.0 updated CHANGES and cython_help.md for a note about the `c_ascii_structure` argument Consistent free of `c_ascii_structure` in thermoanalysis.pyx methods * fixes missing `thal_result.sec_struct` and `dpal_results.sec_struct` (#112) initialization to `NULL` in `recalc_primer_sec_struct` in `libprimer3.c` and `libprimer3flex.c`. `CHANGES` updated * doc string update for _ThermoAnalysis.run_design for new list based keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #111 to address missing
thal_result.sec_structanddpal_results.sec_structinitialization toNULLinrecalc_primer_sec_structinlibprimer3.candlibprimer3flex.cThis resulted in
PRIMER_SECONDARY_STRUCTURE_ALIGNMENTbeing set to 1 causing a segmentation fault.