Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kw_only dataclass fix primer3 py arguments #68

Merged
merged 1 commit into from
Jan 17, 2023
Merged

kw_only dataclass fix primer3 py arguments #68

merged 1 commit into from
Jan 17, 2023

Conversation

grinner
Copy link
Contributor

@grinner grinner commented Jan 17, 2023 •
edited
Loading

remove kw_only kwarg for dataclass as it is Python 3.10 only

benpruitt
benpruitt approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@benpruitt benpruitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@grinner grinner merged commit 8c62a55 into libnano:1.0.0-staging Jan 17, 2023
@grinner grinner deleted the grinner-kw-only-dataclass-fix-Primer3PyArguments branch January 17, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpruitt benpruitt benpruitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grinner @benpruitt