Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

**BREAKING** Return the number of dtype entries from memory::size(). #711

Merged

Conversation

kris-rowe
Copy link
Member

Closes #687.

@kris-rowe kris-rowe linked an issue Oct 20, 2023 that may be closed by this pull request
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #711 (4a79e9a) into development (ce6f23c) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #711      +/-   ##
===============================================
- Coverage        75.24%   75.23%   -0.01%     
===============================================
  Files              299      298       -1     
  Lines            19398    19397       -1     
===============================================
- Hits             14596    14594       -2     
- Misses            4802     4803       +1     
Files Coverage Δ
include/occa/functional/array.hpp 94.15% <100.00%> (ø)
src/core/memory.cpp 84.71% <100.00%> (+0.19%) ⬆️

... and 2 files with indirect coverage changes

@kris-rowe kris-rowe marked this pull request as ready for review November 30, 2023 18:53
@kris-rowe kris-rowe force-pushed the feature/memory-dtype-sizing branch 3 times, most recently from b205e89 to f4d862e Compare December 15, 2023 03:27
@kris-rowe kris-rowe force-pushed the feature/memory-dtype-sizing branch 2 times, most recently from 12119d3 to 010fb44 Compare December 15, 2023 04:13
@kris-rowe kris-rowe merged commit c17644b into libocca:development Dec 15, 2023
8 checks passed
@kris-rowe kris-rowe deleted the feature/memory-dtype-sizing branch December 15, 2023 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

memory::size() should return number of dtype entries
1 participant