Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sha #165

Merged
merged 11 commits into from
Sep 14, 2021
Merged

sha #165

merged 11 commits into from
Sep 14, 2021

Conversation

turuslan
Copy link
Contributor

@turuslan turuslan commented Sep 1, 2021

  • remove [[deprecated]] from sha256()/sha512().

  • sha256()/sha512() return outcome.

  • remove sha256()/sha512() from string (bytes-chars conversion is commonly used, should make separate convertion functions).

  • Hasher::digestOut() that doesn't allocate (result vector).

  • change Sha256{} usages with single write() tosha256().

  • clang-tidy, clang-format.

  • inconsistent use of BOOST_ASIO_NO_DEPRECATED is unnecessary and dangerous #166.

  • fix wrong callback in yamux_stream.hpp.

Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan turuslan requested a review from xDimon September 9, 2021 09:01
include/libp2p/protocol/kademlia/node_id.hpp Outdated Show resolved Hide resolved
src/crypto/sha/sha256.cpp Outdated Show resolved Hide resolved
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan turuslan merged commit b6de6a9 into master Sep 14, 2021
@turuslan turuslan deleted the fix/sha branch September 14, 2021 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants