Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in Transport Concept Docs- regular addressing of TCP port doesn't match multiaddr TCP port #57

Closed
tesla809 opened this issue Jun 25, 2019 · 1 comment

Comments

@tesla809
Copy link

Found a small typo in the Transport docs in the Concepts section.

In the section explaining multiaddresses, shouldn't the TCP ending of the multiaddress: /ip4/7.7.7.7/tcp/6543 match the more familiar construction 7.7.7.7:6542?

7.7.7.7:6542 =? /ip4/7.7.7.7/tcp/6543

Here’s an example of a multiaddr for a TCP/IP transport:

/ip4/7.7.7.7/tcp/6543
This is equivalent to the more familiar 7.7.7.7:6542 construction, but it has the advantage of being explicit about the protocols that are being described. With the multiaddr, you can see at a glance that the 7.7.7.7 address belongs to the IPv4 protocol, and the 6543 belongs to TCP.

@tesla809 tesla809 changed the title Typo in Transport Concept Docs Typo in Transport Concept Docs- regular addressing of TCP port doesn't match multiaddr TCP port Jun 25, 2019
@p-shahi
Copy link
Member

p-shahi commented Aug 26, 2022

Addressed by #146

@p-shahi p-shahi closed this as completed Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants