Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: archive go-libp2p-webrtc-direct #74

Merged
merged 8 commits into from
Nov 22, 2022

Conversation

p-shahi
Copy link
Member

@p-shahi p-shahi commented Nov 9, 2022

Summary

Archive said repo

Why do you need this?

For reasons mentioned in this comment: libp2p/go-libp2p-webrtc-direct#53 (comment)

What else do we need to know?

cc: @backkem who is listed as the lead maintainer of the repo

DRI: myself

Reviewer's Checklist

  • It is clear where the request is coming from (if unsure, ask)
  • All the automated checks passed
  • The YAML changes reflect the summary of the request
  • The Terraform plan posted as a comment reflects the summary of the request

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2022

Before merge, verify that all the following plans are correct. They will be applied as-is after the merge.

Terraform plans

libp2p

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # github_repository.this["go-libp2p-webrtc-direct"] will be updated in-place
  ~ resource "github_repository" "this" {
      ~ archived               = false -> true
        id                     = "go-libp2p-webrtc-direct"
        name                   = "go-libp2p-webrtc-direct"
        # (27 unchanged attributes hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

Copy link
Contributor

@BigLep BigLep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself looks good to me, but I'd like to see an archival notice at the top of https://github.com/libp2p/go-libp2p-webrtc-direct#readme that points someone to why it's deprecated and what is coming along to replace it.

@p-shahi p-shahi changed the title chore: archive go-libp2p-webrtc-direct [do not merge yet] chore: archive go-libp2p-webrtc-direct Nov 10, 2022
@galargh
Copy link
Contributor

galargh commented Nov 10, 2022

The change itself looks good to me, but I'd like to see an archival notice at the top of https://github.com/libp2p/go-libp2p-webrtc-direct#readme that points someone to why it's deprecated and what is coming along to replace it.

Idea for the future: it'd be cool to be able to prepare it inline in a PR like this one and let the automation stick it on top of the README before archiving it.

@backkem
Copy link

backkem commented Nov 13, 2022

Happy to see the official implementation maturing. Great work 👌

Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections from my end.

@p-shahi p-shahi mentioned this pull request Nov 22, 2022
5 tasks
@BigLep
Copy link
Contributor

BigLep commented Nov 22, 2022

Per above, I'm good to merge. Lets also add a clear notification at the top of the repo.

⚠️⚠️⚠️⚠️⚠️⚠️

Status: Archived and not maintained
Alternatives: link
Questions: ask in the repo above

⚠️⚠️⚠️⚠️⚠️⚠️

or something like this

@p-shahi p-shahi changed the title [do not merge yet] chore: archive go-libp2p-webrtc-direct chore: archive go-libp2p-webrtc-direct Nov 22, 2022
@p-shahi p-shahi merged commit 0e08ed6 into master Nov 22, 2022
@p-shahi p-shahi deleted the archive-go-libp2p-webrtc-direct branch November 22, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants