-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: archive go-libp2p-webrtc-direct #74
Conversation
Before merge, verify that all the following plans are correct. They will be applied as-is after the merge. Terraform planslibp2p
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change itself looks good to me, but I'd like to see an archival notice at the top of https://github.com/libp2p/go-libp2p-webrtc-direct#readme that points someone to why it's deprecated and what is coming along to replace it.
Idea for the future: it'd be cool to be able to prepare it inline in a PR like this one and let the automation stick it on top of the README before archiving it. |
Happy to see the official implementation maturing. Great work 👌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No objections from my end.
Per above, I'm good to merge. Lets also add a clear notification at the top of the repo.
|
Summary
Archive said repo
Why do you need this?
For reasons mentioned in this comment: libp2p/go-libp2p-webrtc-direct#53 (comment)
What else do we need to know?
cc: @backkem who is listed as the lead maintainer of the repo
DRI: myself
Reviewer's Checklist