move go-libp2p-resource-manager here #1564
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avoid the nil is not nil footgun
metrics collection support
- include stat at point of rejection. - log constraining edge at point of rejection to include the edge and its stat.
improve debug logging
This is to avoid extra complexity in consumers that expose this config to users through other means or want to build the config programmatically, but are currently required to redefine these structs and keep them in sync. The coupling is already there, we might as well export these structs and reduce maintenance costs.
feat: export basic limiter config
Stebalien
approved these changes
Jun 1, 2022
|
So there is a bunch of activity here, with tooling that needs to be created -- see all the new issues. I propose we delay the merge until these are resolved. |
|
Agreed. Converting to draft. We should also move the README. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1556.