New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autonat: fix closing of listeners in dialPolicy tests #2226

Merged

marten-seemann merged 1 commit into libp2p:master from sukunrt:autonat-test-cleanup

Apr 5, 2023

Member

sukunrt commented Mar 27, 2023 •

edited

this removes these lines from the test logs:

2023-03-26T19:56:27.2037777Z 2023-03-26T19:56:21.026Z	ERROR	swarm2	swarm/swarm_listen.go:118	swarm listener unintentionally closed

These lines are logged always currently. One example is in this test run.
https://github.com/libp2p/go-libp2p/actions/runs/4525497218/jobs/7971850397?pr=2225


          autonat: clean up dialPolicy tests properly

3862b6e

sukunrt requested a review from MarcoPolo

March 27, 2023 08:57

marten-seemann approved these changes

View reviewed changes

marten-seemann changed the title ~~autonat: clean up dialPolicy tests properly~~ autonat: fix closing of listeners in dialPolicy tests

marten-seemann merged commit 88132e9 into libp2p:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment