Skip TestMdnsDiscovery #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Stebalien
approved these changes
Feb 14, 2018
There was a problem hiding this comment.
LGTM but I'd like a signoff from @whyrusleeping.
Note: I've tried increasing the timeout to 3s and it didn't make a difference.
|
Can we file an issue (or two) to make sure we get this passing soon? and have tests just for this |
marten-seemann
added a commit
that referenced
this pull request
Apr 21, 2022
simplify the DialSync code
marten-seemann
pushed a commit
that referenced
this pull request
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tests fails about 9 out of 10 times for me, making the use of gx-workspace on libp2p related trees rather annoying.
Should get re-enabled after #257 is done.