Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add more info to "protocol mux failed" #2734

Merged
merged 3 commits into from
Mar 21, 2024
Merged

add more info to "protocol mux failed" #2734

merged 3 commits into from
Mar 21, 2024

Conversation

zhiqiangxu
Copy link
Contributor

We also met this issue, it may help to provide more info besides "protocol mux failed"

@sukunrt
Copy link
Member

sukunrt commented Mar 15, 2024

You probably want to improve the error message in go-multistream. s.Protocol() will be empty string here since the protocol selection failed.

@zhiqiangxu
Copy link
Contributor Author

You probably want to improve the error message in go-multistream. s.Protocol() will be empty string here since the protocol selection failed.

It seems MultistreamMuxer.Negotiate don't have too much info since its argument is ReadWriteCloser. I removed Protocol since it's always empty.

sukunrt
sukunrt approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@sukunrt sukunrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zhiqiangxu

@zhiqiangxu
Copy link
Contributor Author

It seems the ci failure isn't related to this PR?

@MarcoPolo
Copy link
Collaborator

No worries, I'll rerun. We have some flaky tests I need to debug.

@sukunrt sukunrt merged commit e416c52 into libp2p:master Mar 21, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sukunrt sukunrt sukunrt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhiqiangxu @sukunrt @MarcoPolo