Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ErrReset #37

Merged
merged 1 commit into from
Feb 16, 2019
Merged

Use ErrReset #37

merged 1 commit into from
Feb 16, 2019

Conversation

anacrolix
Copy link
Contributor

Improves error equality checking.

@anacrolix
Use ErrReset
612820a 
Improves error equality checking.
@ghost ghost assigned anacrolix Feb 15, 2019
@ghost ghost added the status/in-progress In progress label Feb 15, 2019
@Stebalien
Copy link
Member

LGTM. The go version in Travis needs updating.

@anacrolix anacrolix mentioned this pull request Feb 16, 2019
Open
@anacrolix anacrolix merged commit 04084d5 into master Feb 16, 2019
@ghost ghost removed the status/in-progress In progress label Feb 16, 2019
@Stebalien
Copy link
Member

Stebalien commented Feb 18, 2019 •
edited
Loading

Let's avoid merging PRs without CI passing (except in special cases). This PR is missing a gx update of go-stream-muxer. Doesn't currently depend on go-stream-muxer (I should have caught that).

@anacrolix anacrolix deleted the err-reset branch February 19, 2019 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien approved these changes

@whyrusleeping whyrusleeping Awaiting requested review from whyrusleeping

Assignees

@anacrolix anacrolix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anacrolix @Stebalien