Avoid double-closing channels #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing us to: 1. Panic. 2. Try to close the stream. 3. Try to re-take the lock while closing the stream (and deadlock). fixes ipfs/kubo#4038
|
I'm guessing this happens when the remote side closes the stream twice at the same time (there's a race where we can send a close twice). |
Stebalien
force-pushed
the
fix/ipfs/go-ipfs#4038
branch
from
a8a92e8
to
a486f6d
Compare
Stebalien
commented
Jul 28, 2017
stream.go
Outdated
| @@ -136,6 +134,8 @@ func (s *Stream) Close() error { | |||
| s.closedLocal = true | |||
| s.clLock.Unlock() | |||
|
|
|||
| err := s.mp.sendMsg((s.id<<3)|Close, nil, time.Time{}) | |||
|
|
|||
There was a problem hiding this comment.
Was there a reason to do this in the other order? I see a commit message talking about a "write-close" edge case.
There was a problem hiding this comment.
Yes, this is a problem. We can end up closing the connection before all closes are sent.
This was referenced Jul 28, 2017
Closed
Stebalien
force-pushed
the
fix/ipfs/go-ipfs#4038
branch
from
a486f6d
to
d7524b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing us to:
fixes ipfs/kubo#4038