Implement new CloseWrite/CloseRead interface #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
requested review from
vyzo and
willscott
and removed request for
vyzo
Stebalien
force-pushed
the
feat/rw-close
branch
from
510b0c1
to
edfbad3
Compare
Close now closes the stream in both directions while CloseRead discards inbound bytes and CloseWrite sends an EOF. This matches the user's expectation where Close actually closes the stream. part of libp2p/go-libp2p-core#166
Stebalien
force-pushed
the
feat/rw-close
branch
from
edfbad3
to
81349d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close now closes the stream in both directions while CloseRead discards inbound bytes and CloseWrite sends an EOF. This matches the user's expectation where Close actually closes the stream.
part of libp2p/go-libp2p-core#166