This repository has been archived by the owner on May 26, 2022. It is now read-only.
Add 10s dial timeout #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to have granular timeouts. My plan is to have a global 60s dial timeout but have each layer/transport decide how long its timeouts should be. Note: This timeout matches what we used to have in swarm (before we decided to complete the secio handshake early).
ghost
assigned 
|
As @whyrusleeping pointed out, this isn't our job. The caller should just set a context-wide timeout and we should obey that. We may reconsider this at some point if it becomes an issue but we'll punt till then. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to have granular timeouts. My plan is to have a global 60s dial
timeout but have each layer/transport decide how long its timeouts should be.
Note: This timeout matches what we used to have in swarm (before we decided to
complete the secio handshake early).