Skip to content
This repository has been archived by the owner on Jul 21, 2023. It is now read-only.

ECDSA/secp256k1 support #57

Closed
parkan opened this issue Jan 6, 2017 · 3 comments
Closed

ECDSA/secp256k1 support #57

parkan opened this issue Jan 6, 2017 · 3 comments

Comments

@parkan
Copy link

parkan commented Jan 6, 2017

We'd like to be able to verify ECDSA (ethereum) signatures. This should be a fairly small amount of work along the lines of #55

@yusefnapora is on it, opening this here as a head up.

@parkan parkan changed the title ECDSA support ECDSA/secp256k1 support Jan 9, 2017
@parkan
Copy link
Author

parkan commented Jan 9, 2017

@dignifiedquire @diasdavid would adding support for secp256k1 keys here be in scope? It is (unfortunately) relatively non-standard on paper but de facto the standard in both Bitcoin and Ethereum. I am thinking we would still use sha256 hashing as is done elsewhere in libp2p, so keys would be compatible but signatures not necessarily so (i.e. wouldn't be able to verify signatures from web3.eth.verify because that expects Keccak-256), but we could also use Keccak-256.

The motivation here is improving interop with ethereum for oracles.

@daviddias
Copy link
Member

would adding support for secp256k1 keys here be in scope?

You mean adding another keytype? Absolutely, feel welcome to add, bare in mind though that adding types of keys in the future will be way more sane in the 'near' future as multikey develops (each key will be identified by a multicodec, not needing to redefine protobuf files for it). //cc @whyrusleeping

From several conversations I've been having, it seems more and more people are taking libp2p-crypto as their crypto solution for their needs, which is absolutely great, we definitely had to fight a lot to get all of these crypto primitives the most performant way possible in a way that works for nodejs and the browser, just please always bear in mind this hasn't been audited at all when deploying your systems.

That being said, all sounds good :)

@parkan
Copy link
Author

parkan commented Jan 18, 2017

PR open at #60

@daviddias daviddias added the status/deferred Conscious decision to pause or backlog label Jan 19, 2017
@parkan parkan closed this as completed Feb 7, 2017
@RichardLitt RichardLitt removed the status/deferred Conscious decision to pause or backlog label Feb 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants