Skip to content
This repository has been archived by the owner on Jun 19, 2023. It is now read-only.

test: run tests on webkit #177

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

achingbrain
Copy link
Member

Adds a test:webkit script so we can run tests on webkit in CI.

Adds a `test:webkit` script so we can run tests on webkit in CI.
@maschad maschad self-assigned this Jun 7, 2023
@maschad maschad marked this pull request as draft June 8, 2023 18:06
@maschad maschad requested a review from MarcoPolo June 8, 2023 18:06
test/basics.spec.ts Outdated Show resolved Hide resolved
@maschad
Copy link
Member

maschad commented Jun 8, 2023

So it seems there isn't parity across the Linux Webkit implementations on playwright which was causing these tests to fail on a linux vm for webkit. There is currently an open issue to add support for better testing WebRTC applications with Webkit but in the interim I suggest we run the webkit tests on a macOS instance until that's resolved.

@maschad maschad marked this pull request as ready for review June 8, 2023 23:07
@maschad
Copy link
Member

maschad commented Jun 13, 2023

So it seems there isn't parity across the Linux Webkit implementations on playwright which was causing these tests to fail on a linux vm for webkit. There is currently an open issue to add support for better testing WebRTC applications with Webkit but in the interim I suggest we run the webkit tests on a macOS instance until that's resolved.

Update: So I did some more research/testing and found that WebkitGTK (the full-featured port of the WebKit rendering engine on Linux-based OS's) does not yet support the PeerConnection API. Igalia is currently working on the implementation but this is obviously a blocker for Playwright supporting this interface.

Thanks to @MarcoPolo for pointing me in this direction.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants