fix dial function name and multiaddr variable name in echo and chat d… #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ialer/listener examples
daviddias
approved these changes
Jul 11, 2017
maschad
pushed a commit
to maschad/js-libp2p
that referenced
this pull request
Jun 21, 2023
* fix: Fetch local fingerprint from SDP Since firefox does not support `getFingerprints`, we fetch the local fingerprint from the PeerConnection's `localDescription` field by parsing the fingerprint line from the SDP. * remove erroneous comment * update sdp * working browser-to-server in firefox * test firefox browser-to-server in CI * remove hack * address review comment * Review nits * Rename test file for playwright * Build once for browser tests * Move code back to make diff smaller --------- Co-authored-by: Marco Munizaga <git@marcopolo.io>
maschad
pushed a commit
to maschad/js-libp2p
that referenced
this pull request
Jun 21, 2023
## [1.1.10](libp2p/js-libp2p-webrtc@v1.1.9...v1.1.10) (2023-05-03) ### Bug Fixes * Fetch local fingerprint from SDP ([libp2p#109](libp2p/js-libp2p-webrtc#109)) ([3673d6c](libp2p/js-libp2p-webrtc@3673d6c))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ialer/listener examples