Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update PubSub Example test #1543

Closed
wants to merge 1 commit into from

Conversation

maschad
Copy link
Member

@maschad maschad commented Jan 11, 2023

Closes #1540

@achingbrain
Copy link
Member

Ah, whoops - I didn't see this sorry.

It's not necessary for node1 and node3 to be connected as node2 should relay messages to node3.

Instead we need to wait for node1 to know node2 is subscribed to the topic, and that node2 knows node3 is subscribed to the topic.

See the fix here: #1549

@maschad
Copy link
Member Author

maschad commented Jan 16, 2023

Ah, whoops - I didn't see this sorry.

It's not necessary for node1 and node3 to be connected as node2 should relay messages to node3.

Instead we need to wait for node1 to know node2 is subscribed to the topic, and that node2 knows node3 is subscribed to the topic.

See the fix here: #1549

Understood. I thought that node1 needed to also have node3 in it's subscriber list in order for the messages to be relayed to node3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Flakey Tests on CI for PubSub examples
2 participants