fix: interpret circuit relay expiry as seconds #1636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes #1635 which causes the circuit relay to repeatedly connect to a discovered relay. If the relay returns connection expiration in seconds, we get a negative ttl when calculating `expiration - new Date().getTime()`. This caused the `addRelay` function to set the timeout at 0ms. This timeout instantly triggers and calls `addRelay` recursively.
ckousik
commented
Mar 21, 2023
achingbrain
reviewed
Mar 21, 2023
achingbrain
reviewed
Mar 21, 2023
achingbrain
reviewed
Mar 21, 2023
|
@achingbrain I've bounded the timeout duration between 30 seconds and 15 minutes. The values are arbitrary for now. |
achingbrain
reviewed
Mar 21, 2023
achingbrain
reviewed
Mar 21, 2023
achingbrain
reviewed
Mar 21, 2023
achingbrain
changed the title
achingbrain
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1635 which causes the circuit relay to repeatedly connect to a discovered relay. If the relay returns connection expiration in seconds, we get a negative ttl when calculating
expiration - new Date().getTime().This caused the
addRelayfunction to set the timeout at 0ms. This timeout instantly triggers and callsaddRelayrecursively.