fix: callback with error for invalid or non-peer multiaddr #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Alan Shaw <alan@tableflip.io>
ghost
assigned 
jacobheun
approved these changes
Aug 13, 2018
maschad
pushed a commit
to maschad/js-libp2p
that referenced
this pull request
Jun 21, 2023
Refactors benchmark to use exported factory function instead of instantiating an instance of the class which is no longer exported.
maschad
pushed a commit
to maschad/js-libp2p
that referenced
this pull request
Jun 21, 2023
## [7.0.4](libp2p/js-libp2p-mplex@v7.0.3...v7.0.4) (2022-11-23) ### Dependencies * **dev:** bump it-map from 1.0.6 to 2.0.0 ([libp2p#225](libp2p/js-libp2p-mplex#225)) ([a153108](libp2p/js-libp2p-mplex@a153108)) ### Trivial Changes * update benchmark ([libp2p#232](libp2p/js-libp2p-mplex#232)) ([d73381e](libp2p/js-libp2p-mplex@d73381e))
maschad
pushed a commit
to maschad/js-libp2p
that referenced
this pull request
Jun 21, 2023
* update .github/workflows/js-test-and-release.yml * test: fix tests on node 18 (libp2p#234) We need to specify the host name to connect. If we don't it defaults to `localhost` - it seems in node 17+ DNS resolution has changed to return IPv6 addresses by default which causes the connection to fail because the listener has only bound to an IPv4 address. Co-authored-by: web3-bot <web3-bot@users.noreply.github.com> Co-authored-by: Alex Potsides <alex@achingbrain.net>
maschad
pushed a commit
to maschad/js-libp2p
that referenced
this pull request
Jun 21, 2023
libp2p streams are now explicit about the types of sync/sources they provide, showing that they are `AsyncGenerator`s and not just `AsyncIterable`s. Refs: achingbrain/it-stream-types#45 BREAKING CHANGE: the type of the source/sink properties have changed
maschad
pushed a commit
to maschad/js-libp2p
that referenced
this pull request
Jun 21, 2023
## [6.0.0](libp2p/js-libp2p-websockets@v5.0.10...v6.0.0) (2023-04-18) ### ⚠ BREAKING CHANGES * the type of the source/sink properties have changed ### Dependencies * update stream types ([libp2p#232](libp2p/js-libp2p-websockets#232)) ([5a69d38](libp2p/js-libp2p-websockets@5a69d38))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
multiaddr(input)can throw, so put a try/catch around this