feat: add webtransport listener #2422
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a transport listener to `@libp2p/webtransport` for Node.js
3 tasks
achingbrain
added a commit
that referenced
this pull request
May 1, 2024
The PR pulls all of the non-`@fails/webtransport` parts out of #2422 There's a lot of work that's been done to re-use existing libp2p code such as the abstract stream class which handles a lot more closing scenarios than the existing implementation so it would be good to get that in.
6 tasks
achingbrain
force-pushed
the
main
branch
2 times, most recently
from
6453a80
to
c2bc7fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a transport listener to
@libp2p/webtransportfor Node.jsIn draft for now, there's some very strange behaviour around closing stream writers in browsers.
A lot has changed with
@fails-components/webtransportsince we last looked at it.Notably it's been rewritten internally and no longer uses it's own event loop which is a marked improvement on the user experience.
Unfortunately some tests that were passing before now fail so there's some investigation to do.
Refs #2371
TODO:
Using promises for callbacks may miss promise rejections? fails-components/webtransport#259feat: support query strings fails-components/webtransport#280Change checklist