fix: time out DHT network requests separately from query #2524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
force-pushed
the
fix/time-out-network-requests
branch
from
9a08273
to
834ef9b
Compare
Apply a per-request timeout to each network request in a DHT query. To avoid having a "one size fits all" timeout, it is adaptive so will increase/decrease based on the average success/failure times during the previous (configurable, default 5s) time interval.
achingbrain
force-pushed
the
fix/time-out-network-requests
branch
from
834ef9b
to
b9c06e9
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply a per-request timeout to each network request in a DHT query.
To avoid having a "one size fits all" timeout, it is adaptive so will increase/decrease based on the average success/failure times during the previous (configurable, default 5s) time interval.
Change checklist