Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Error trait for GetRecordError (Kad) #2612

Closed
Janmajayamall opened this issue Apr 10, 2022 · 2 comments
Closed

Implement Error trait for GetRecordError (Kad) #2612

Janmajayamall opened this issue Apr 10, 2022 · 2 comments

Comments

@Janmajayamall
Copy link
Contributor

I am not sure why Error trait hasn't been implemented for GetRecordError (ref).
@elenaf9
Copy link
Contributor

elenaf9 commented Apr 11, 2022

Error was implemented for all other kademlia error types in #2414, I would guess it was an oversight. Would you mind doing a PR for this?

Janmajayamall added a commit to Janmajayamall/rust-libp2p that referenced this issue Apr 11, 2022
@Janmajayamall
Implements Error for GetRecordError (libp2p#2612)
7b1d4cd
@thomaseizinger
Copy link
Contributor

Let me know if this is still an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@thomaseizinger @Janmajayamall @elenaf9