-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
swarm-derive/lib: Don't clone error on inject_dial_failure #2349
swarm-derive/lib: Don't clone error on inject_dial_failure #2349
Conversation
Yes. Please include the diff below, as otherwise, this won't make it into the next release: diff --git a/CHANGELOG.md b/CHANGELOG.md
index facbdef0..c3112024 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -42,6 +42,11 @@
# `libp2p` facade crate
+## Version 0.41.1 [unreleased]
+
+- Update individual crates.
+ - `libp2p-swarm-derive`
+
## Version 0.41.0 [2021-11-16]
- Update individual crates.
diff --git a/Cargo.toml b/Cargo.toml
index a8d93817..7a013d18 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -2,7 +2,7 @@
name = "libp2p"
edition = "2018"
description = "Peer-to-peer networking library"
-version = "0.41.0"
+version = "0.41.1"
authors = ["Parity Technologies <admin@parity.io>"]
license = "MIT"
repository = "https://github.com/libp2p/rust-libp2p"
@@ -86,7 +86,7 @@ libp2p-relay = { version = "0.5.0", path = "protocols/relay", optional = true }
libp2p-rendezvous = { version = "0.2.0", path = "protocols/rendezvous", optional = true }
libp2p-request-response = { version = "0.14.0", path = "protocols/request-response", optional = true }
libp2p-swarm = { version = "0.32.0", path = "swarm" }
-libp2p-swarm-derive = { version = "0.26.0", path = "swarm-derive" }
+libp2p-swarm-derive = { version = "0.26.1", path = "swarm-derive" }
libp2p-uds = { version = "0.30.0", path = "transports/uds", optional = true }
libp2p-wasm-ext = { version = "0.30.0", path = "transports/wasm-ext", default-features = false, optional = true }
libp2p-yamux = { version = "0.34.0", path = "muxers/yamux", optional = true }
diff --git a/swarm-derive/CHANGELOG.md b/swarm-derive/CHANGELOG.md
index a474845f..18e1eaf7 100644
--- a/swarm-derive/CHANGELOG.md
+++ b/swarm-derive/CHANGELOG.md
@@ -1,3 +1,9 @@
+# 0.26.1 [unreleased]
+
+- Remove unnecessary clone of error in `inject_dial_failure` (see [PR 2349]).
+
+[PR 2349]: https://github.com/libp2p/rust-libp2p/pull/2349
+
# 0.26.0 [2021-11-16]
- Adjust to advanced dialing requests API changes (see [PR 2317]).
diff --git a/swarm-derive/Cargo.toml b/swarm-derive/Cargo.toml
index 01ca2087..3c06a853 100644
--- a/swarm-derive/Cargo.toml
+++ b/swarm-derive/Cargo.toml
@@ -2,7 +2,7 @@
name = "libp2p-swarm-derive"
edition = "2018"
description = "Procedural macros of libp2p-core"
-version = "0.26.0"
+version = "0.26.1"
authors = ["Parity Technologies <admin@parity.io>"]
license = "MIT"
repository = "https://github.com/libp2p/rust-libp2p" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏 Thank you Elena!
Do we have an ETA on when |
@jnicholls I plan to cut |
@mxinden You and other contributors are kicking butt on this OSS project; I expect nothing and fully appreciate and am grateful for everyone's efforts! I would be content if you said next year :) But next week is awesome news, thanks! |
NetworkBehaviour::inject_dial_failure
expects a reference for the error, thus the error should not be cloned when passing it to the inner behaviours in theNetworkBehaviour
derivation.Fixes Issue #2348.
@mxinden do I need to add a Changelog entry for this?