protocols/dcutr: disable libp2p-core default features
#2836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able-libp2p-core-default-features
|
@mxinden do I also need to bump the dependency version in the root |
mxinden
approved these changes
Aug 23, 2022
There was a problem hiding this comment.
Thanks for the fix! Will cut a new release right away.
@mxinden do I also need to bump the dependency version in the root Cargo.toml and bump the libp2p version or is this not necessary because its only a patch version bump?
No need for the bump in the root Cargo.toml.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix
libp2p-dcutris leaking the default features forlibp2p-core.Links to any relevant issues
Workaround for #2833.