Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(metrics): Upgrade to prometheus-client v0.19.0 #3207

Merged
merged 10 commits into from
Jan 3, 2023
Merged

chore(metrics): Upgrade to prometheus-client v0.19.0 #3207

merged 10 commits into from
Jan 3, 2023

Conversation

mxinden
Copy link
Member

@mxinden mxinden commented Dec 7, 2022

Description

Notes

Upgrades to the *upcoming prometheus-client v0.19.0 release. More specifically tests out prometheus/client_rust#105 and prometheus/client_rust#82.

Opening as draft for now until v0.19.0 release.

Links to any relevant issues

Open Questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@thomaseizinger
Copy link
Contributor

thomaseizinger commented Dec 8, 2022 •
edited
Loading

I think you may have forgotten to push the [patch.crates-io] section to make this compile on CI!

thomaseizinger
thomaseizinger approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a smooth upgrade to me!

@thomaseizinger
Copy link
Contributor

libp2p-metrics examples are still failing.

@mxinden mxinden marked this pull request as ready for review January 3, 2023 17:54
@mxinden mxinden added the send-it label Jan 3, 2023
@mergify mergify bot merged commit 2621528 into libp2p:master Jan 3, 2023
@ackintosh ackintosh mentioned this pull request Jan 4, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaseizinger thomaseizinger thomaseizinger approved these changes

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxinden @thomaseizinger