Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(quick-protobuf-codec): replace unsafe with BufMut::put #4911

Closed
wants to merge 1 commit into from
Closed

fix(quick-protobuf-codec): replace unsafe with BufMut::put #4911

wants to merge 1 commit into from

Conversation

mxinden
Copy link
Member

@mxinden mxinden commented Nov 21, 2023

Description

Builds on top of #4782.

Removes the requirement for unsafe code.

Notes & open questions

Here to show the idea (i.e. using BufMut::put). Not polished.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@mxinden
fix(quick-protobuf-codec): replace custom unsafe copy_from_slice with…
4ed5f2c 
… BufMut::put

Builds on top of libp2p#4782.

Removes the requirement for `unsafe` code.
@mxinden mxinden mentioned this pull request Nov 21, 2023
Merged
4 tasks
thomaseizinger
thomaseizinger approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for discovering this! I'll update the original PR!

@thomaseizinger
Copy link
Contributor

Now part of #4782.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaseizinger thomaseizinger thomaseizinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxinden @thomaseizinger