-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add non-linear equality constraints in COBYLA #17
Conversation
@zaikunzhang and @amontoison: Can you have a look at this PR before I merge it? The musl Linux tests failed because of insufficient credits... |
I suggest to add a reference to the Julia package
I checked the logs and we have some |
You are right, I read the log files too quickly. Sorry! Yet I do not see why |
Good idea! Done in a73f854 of this PR. |
Thank you @emmt and @amontoison . I give some comments at #14 for your consideration. In particular, #14 (comment) BTW, due to some urgent deadlines, I will be almost away from GitHub until the end of the month. Thank you for your understanding. |
@emmt Should we remove Linux MUSL from CI? |
@amontoison yes we should perhaps do that because Linux musl is not recommended (on Julia download page) for production use. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check-spelling found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
Issue #4 is solved by this PR. The only remaining issues are the check-spelling ones. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issuccess
is a false positive, it is the name of this method imported from LinearAlgebra
All tests passed. I merge this PR and will trigger a new version (0.2.0) since the API has changed quite substancially... |
This PR fixes issues: