Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dependencies with inline variables #1

Open
johnjohndoe opened this issue Nov 22, 2018 · 1 comment
Open

Support dependencies with inline variables #1

johnjohndoe opened this issue Nov 22, 2018 · 1 comment

Comments

@johnjohndoe
Copy link

Current state

  • Dependencies with the version specified as an inline text are picked up, e.g. compile "com.squareup.okhttp3:okhttp:3.11.0" (example)
  • Dependencies with the version specified as an inline variable are not picked up, e.g. compile "com.squareup.okhttp3:okhttp:$okhttpVersion" (example)

Target state

  • Both, versions defined as inline text or an inline variable are picked up.

Background

  • Groovy allows to use inline variables in double quoted strings. The variable is typically defined in the same .gradle file or in a separate file such as build.gradle in the root of the project or in properties.gradle which can be stored in different locations and also gets read in by gradle.
  • Another common pattern is to store versions and dependencies strings in the special buildSrc/ module. Here is an example implemented in Kotlin but used from within the Groovy build.gradle files.
@johnjohndoe
Copy link
Author

I just realized that I created an issue earlier: librariesio/libraries.io#1976

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants