fix(macro): recognize option references #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OptionalEnum::is_option_type did not properly process references to Options. References to Option types are present in enum values with named fields.
|
Thank you for your PR! |
Merged
|
@6d7a swoops in for another fix. Thanks for this! |
6d7a
added a commit
to 6d7a/rasn
that referenced
this pull request
Feb 3, 2024
* fix(macro): recognize option references OptionalEnum::is_option_type did not properly process references to Options. References to Option types are present in enum values with named fields. * style: cargo fmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #217
OptionalEnum::is_option_typedid not properly process references toOptions. References toOptiontypes are present in enum values with named fields. This PR fixes that behavior and adds a test for it.