Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable long_sequence_of #232

Merged
merged 1 commit into from
Mar 17, 2024
Merged

Conversation

Trolldemorted
Copy link
Contributor

No description provided.

@Trolldemorted
Copy link
Contributor Author

failures:

---- est::tests::csr_attributes_decode_2 stdout ----
thread 'est::tests::csr_attributes_decode_2' panicked at library\alloc\src\raw_vec.rs:570:5:
capacity overflow
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


failures:
    est::tests::csr_attributes_decode_2

test result: FAILED. 5 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 1226.99s

Is that an oom error?

@XAMPPRocky
Copy link
Collaborator

I believe it's the amount of items exceeds the size of a pointer. The capacity is the size of a pointer on the platform.

@Trolldemorted
Copy link
Contributor Author

Do you have then any clue why that particular test would fail? Since we smell something fishy again, what could be our causes?

  • A bug in that version of Rust beta on i686?
  • A spurious bug that just happens once every few runs?
  • A bug in rasn that occurs only if you execute it on a x86 machine and not on x64 with cargo test --target i686-pc-windows-msvc?

Could you restart the CI job and we observe whether this happens everytime?

@XAMPPRocky
Copy link
Collaborator

I've restarted it now.

@XAMPPRocky
Copy link
Collaborator

Seems like it was just spurious. Thank you for your PR!

@XAMPPRocky XAMPPRocky merged commit e01c818 into librasn:main Mar 17, 2024
65 checks passed
@Trolldemorted
Copy link
Contributor Author

Could you fix the CI on the master branch? Then we'd have at least some history of when and how often things fail, right now almost every commit fails

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants