Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android Support #75

Closed
trymeouteh opened this issue Feb 28, 2022 · 44 comments
Closed

Android Support #75

trymeouteh opened this issue Feb 28, 2022 · 44 comments
Labels
enhancement New feature or request Firefox-Android For issues related to Firefox Android which isn't supported officialy

Comments

@trymeouteh
Copy link

If possible could this extension be modified to work on Android firefox based browser and Android chromium browsers.

@ManeraKai
Copy link
Member

I'll see

@ManeraKai ManeraKai added the enhancement New feature or request label Feb 28, 2022
@catwithbanana
Copy link

The extension works just fine if you use Firefox Nightly or a fork like Mull, which allow loading non-curated extensions. The set-up is more annoying than it should be (thanks Mozilla) but everything functions as expected.

@ManeraKai
Copy link
Member

ManeraKai commented Mar 1, 2022

I can publish it for android too. The only thing I'm concerning with is the interface.
I'll release the new version for android.

@ManeraKai
Copy link
Member

Seems Firefox doesn't allow any extensions other than the ones that it recommends. They're 17 only. So the extension needs to be reviewed and recommended by Firefox staff to show up.

@ManeraKai
Copy link
Member

The extension has support for Android, but isn't in https://addons.mozilla.org/en-US/android/ store yet. I'll close this issue as I can't do anything other than waiting.

@linsui
Copy link

linsui commented Mar 30, 2022

The extension has a small problem on Android that the setting page is opened but I'm still on the previous page. This is the behavios on the desktop but on Android it's strange and unconvient.

@ManeraKai
Copy link
Member

How is that?

@linsui
Copy link

linsui commented Mar 30, 2022

uBlock Origin's example: https://github.com/gorhill/uBlock/blob/0c7318d6f749ef852c36c76e278048816c2f2f8c/src/popup.html#L23 I guess the target attribute is important.

@ManeraKai
Copy link
Member

So you need to open it in a new tab when you click on the Settings button right?

@linsui
Copy link

linsui commented Mar 30, 2022

I hope that I'm brought to the opened tab when I click on the Settings. On Android the tab is opened but I'm left on the popup page.

@ManeraKai
Copy link
Member

I see now. So it opens on a new tab but not focused to it.

@linsui
Copy link

linsui commented Mar 30, 2022

Yes. On Android it's annoying since I need to return to the origin page and switch to the new page.

@kartikdc
Copy link

kartikdc commented Apr 8, 2022

Can someone tell me how to install this extension on Firefox Nightly on Android? I have been able to enable the debug menu to allow adding custom add-on collections but not sure if that is the right way to go about it.

@linsui
Copy link

linsui commented Apr 8, 2022

Since you have enabled custom add-on collections, you can add a collention containing this extension.

@ManeraKai
Copy link
Member

I think I should add those steps to the wiki.

@kartikdc
Copy link

You can link this blog post in the README. The instructions here are clear enough and there are screenshots too.

https://blog.mozilla.org/addons/2020/09/29/expanded-extension-support-in-firefox-for-android-nightly/

@ManeraKai
Copy link
Member

@austinhuang0131 remembered me that there is already a phone app called UntrackMe: #184 (comment). It's now mentioned in the README. I'll close the issue and won't add the blog to the wiki as I won't support Android. It's much easier to handle links using a system app rather than a browser when using phones.

@linsui
Copy link

linsui commented Apr 12, 2022

UntrackMe is great but it can't replace libredirect by any means. If I have a twitter link and I want to open it in nitter, I have to share it to UntrackMe first while libredirect provides much more seamless experience. Libredirect also has more control over the webpage, e.g. it can force the same settings on all instance. It's also very useful that I can sync the settings between desktop and mobile. Due to Mozilla's restrictions it's reasonable not to support Android but I hope that contributions will be accepted.

@ManeraKai
Copy link
Member

ManeraKai commented Apr 12, 2022

UntrackMe is great but it can't replace libredirect by any means. If I have a twitter link and I want to open it in nitter, I have to share it to UntrackMe first while libredirect provides much more seamless experience.

This is needed so if you want to either copy the link rather than opening it in a browser. All your life isn't in the browser when using a mobile phone.

Libredirect also has more control over the webpage, e.g. it can force the same settings on all instance.

I agree. I suggest helping UntrackMe and making those settings available on it.

It's also very useful that I can sync the settings between desktop and mobile. Due to Mozilla's restrictions it's reasonable not to support Android but I hope that contributions will be accepted.

This was true before, but a big problem came and we stopped using sync storage. We're no using local storage.

@linsui
Copy link

linsui commented Apr 12, 2022

This is needed so if you want to either copy the link rather than opening it in a browser. All your life isn't in the browser when using a mobile phone.

Oh, great, I just found that I can make Firefox always open the link in UntrackMe and UntrackMe always open the link in Firefox. It's not so seamless but works well enough.

I agree. I suggest helping UntrackMe and making those settings available on it.

I don't know if it's possible to do that in an app though. Currently libredirect already has much richer features than UntrackMe for me.

This was true before, but a big problem came and we stopped using sync storage. We're no using local storage.

I can still export and import the settings which is better than tweak those settings manully on every device.

Additionally, it's much easier for me to help libredirect works well on Android than UntractMe.

@ManeraKai ManeraKai reopened this Apr 12, 2022
@austinhuang0131
Copy link
Contributor

austinhuang0131 commented Apr 12, 2022

But can you do this in an app (read: not an extension on mobile) in a way more seamless than UntrackMe though? (For me I can open with UntrackMe with my default browser whenever I click any link from any non-browser app; in browser this only applies to frontend-able URLs.) Really the only things missing in it are auto updating instances and round robin which should not require reinventing the wheel. UntrackMe sends settings (Invidious) as a query string, I don't think it can modify cookies.

@ManeraKai
Copy link
Member

Many other frontends/services don't use url queries, many of them even remove them if you clicked another link in the site or got redirected. url queries isn't a reliable option.
I remember that typing https://invidious.kavin.rocks/?dark_mode=true will get your redirected to https://invidious.kavin.rocks/feed/popular and the queries are removed.

@austinhuang0131
Copy link
Contributor

yes but can you modify cookies in an URL intent from an external app

@ManeraKai
Copy link
Member

How is that?

@0x6e656b6f
Copy link

Can you add Newpipe? If you long tap a link, there's an "Open link in external app" option in Firefox. Maybe you could use that option to automatically redirect Youtube link to open in Newpipe.

@0x6e656b6f
Copy link

Also I tested the extension in Firefox Nightly, most stuff works but there's a crash when clicking on site settings. Here's some step to reproduce:

  1. Addons > LibRedirect
  2. Nightly opens LibRedirect settings in a mobile friendly UI.
  3. Tap on "YouTube" or the icon to modify the YouTube settings.
  4. Nightly crashed.

The crash however don't occur when you open the extension using moz-extension://extension-id URL (using that URL also opens the normal UI that don't look mobile friendly).

@ManeraKai
Copy link
Member

Can you add Newpipe? If you long tap a link, there's an "Open link in external app" option in Firefox. Maybe you could use that option to automatically redirect Youtube link to open in Newpipe.

NewPipe should support this natively. I don't know if they do but I LibreTube has that.

@ManeraKai
Copy link
Member

Nightly opens LibRedirect settings in a mobile friendly UI.

That's interesting, how does that look?

@0x6e656b6f
Copy link

Can you add Newpipe? If you long tap a link, there's an "Open link in external app" option in Firefox. Maybe you could use that option to automatically redirect Youtube link to open in Newpipe.

NewPipe should support this natively. I don't know if they do but I LibreTube has that.

That's only for YouTube link that's not in the web browser. But if you type youtube.com then press Enter in the browser search bar, then Newpipe won't open. Clicking YT URL from search engine result opens up Newpipe but also opens up YT tab and load the video there.

@0x6e656b6f
Copy link

Nightly opens LibRedirect settings in a mobile friendly UI.

That's interesting, how does that look?

image

@Mrnofish
Copy link

BTW while it does work on Android, the settings arent' working as nicely as expected, e.g. as well as uBlock Origin.

For instance, when I tap on Settings, the new Settings tab opens in the background, and it is necessary to tap the back button for it to show.

Additionally, since the menu is displayed on the left, most of the actual settings are outside of the viewport, and there is a ton of blank space between the controls on the right and the description on the left. In short, it's like it's assuming a display whose proportions are those of a regular PC monitor rather than the narrow/tall screen of a typical current smartphone.

@MintMain21
Copy link

Update: Firefox officially supports extensions on Android now.

You'll have to update it on your end to mark it as Android compatible, let alone test it.

@ManeraKai ManeraKai reopened this Dec 12, 2023
@opusforlife2
Copy link

Android support would be fantastic. Right now I have to open websites in new tabs via sharing links to UntrackMe, which modifies the URL and returns it to the browser. This extension would massively improve convenience (not to mention vastly increase the number of supported websites).

@Nitrousoxide
Copy link

Android support would be fantastic. Right now I have to open websites in new tabs via sharing links to UntrackMe, which modifies the URL and returns it to the browser. This extension would massively improve convenience (not to mention vastly increase the number of supported websites).

You can use https://addons.mozilla.org/en-US/firefox/addon/redirector/ in the meantime as it's in the mobile extension repo though it is hardly ideal since you need to make your own redirection rules.

Here's a simple redirector from twitter/x -> a nitter instance you can load into it and tweak.

https://gist.github.com/Nitrousoxide/7419625b6c7bf82a7ace080d60f739f5

Libredirect would be far superior though.

@Mrnofish
Copy link

Mrnofish commented Dec 17, 2023

As suggested previously, LibRedirect has already been working on Android, just as long as it is added to a personal collection on AMO.

This feature is available on Firefox Beta/Nightly and Fennec, probably other forks that I've never used, too.

No need to jump through hoops or put up with outdated or more limited software.

@opusforlife2
Copy link

No need to jump through hoops

just as long as it is added to a personal collection on AMO.

Bit of a contradiction there. 🤭

@unchartedpopsicle
Copy link

There is no need for that hoop, either. On the latest Firefox stable you can just open the add-on page in desktop mode and install directly.

@MintMain21
Copy link

image

Just add the "Android" badge plz.

@IkelAtomig
Copy link
Member

IkelAtomig commented Dec 18, 2023

But don't be furious if it didn't work out well. Open a new issue titled as Problems in Android Version.

We are preparing for a new release. So, Will enable when it is released.

@IkelAtomig IkelAtomig changed the title Android Android Support Dec 18, 2023
@ManeraKai
Copy link
Member

@MintMain21 I added the badge.

@opusforlife2
Copy link

Open a new issue titled as Problems in Android Version

Shouldn't we report bugs one by one in separate issues so that there is no clutter?

@opusforlife2
Copy link

Hallelujah! It works! It's alive!

@ManeraKai
Copy link
Member

Shouldn't we report bugs one by one in separate issues so that there is no clutter?

@opusforlife2 I'll add the label Firefox-Android for them.

@ManeraKai ManeraKai added the Firefox-Android For issues related to Firefox Android which isn't supported officialy label Dec 18, 2023
@ManeraKai
Copy link
Member

I'll close this issue and complete it in the other sub-issues: #874, #873

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Firefox-Android For issues related to Firefox Android which isn't supported officialy
Development

No branches or pull requests