Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User should be able to login via Facebook OAuth. #11

Closed
ggajos opened this issue Feb 23, 2015 · 72 comments
Closed

User should be able to login via Facebook OAuth. #11

ggajos opened this issue Feb 23, 2015 · 72 comments
Assignees

Comments

@ggajos
Copy link

ggajos commented Feb 23, 2015

User should be able to login via Facebook OAuth but there is no notion about this in code yet.

We should use provided access codes and PsFacebook class is implemented in Takes 0.5

Access codes:

  • facebook acc ID:provided via file`
  • secret code:provided via file`

Please use suggested by Yegor way of providing those values (see #11 (comment))

@ggajos
Copy link
Author

ggajos commented Feb 23, 2015

@karato it's a valid bug

@karato karato added the bug label Feb 23, 2015
@karato
Copy link

karato commented Feb 23, 2015

@karato it's a valid bug

@ggajos thanks, I added the "bug" tag

@karato
Copy link

karato commented Feb 23, 2015

we will find someone to do this task, soon

@karato
Copy link

karato commented Feb 23, 2015

@darkled this is your task

@asaen
Copy link

asaen commented Feb 23, 2015

@karato please assign someone else to this issue

@yegor256
Copy link
Contributor

@ggajos could you please reformat this ticket so that it starts sound like a bug. I'm not sure I understand now what is broken and what do you expect someone to fix

@ghost
Copy link

ghost commented Feb 23, 2015

@ggajos @yegor256 this seems more like a suggestion for handling the oauth tokens on our end than a bug, perhaps?

@yegor256
Copy link
Contributor

@k0r that's exactly my point. @ggajos please reformat the ticket so that it sounds like a bug and becomes fixable

@karato
Copy link

karato commented Feb 24, 2015

@karato please assign someone else to this issue

@darkled someone else will help in this task, no problem at all

@karato
Copy link

karato commented Feb 24, 2015

@pinaf this is your task

@pinaf
Copy link
Contributor

pinaf commented Feb 24, 2015

@karato please assign to someone else. no facebook for me, sorry.

@karato
Copy link

karato commented Feb 24, 2015

@ggajos many thanks for the bug report, I added 15 mins to your acc, transaction AP-1MM44861123518100

@pinaf
Copy link
Contributor

pinaf commented Feb 24, 2015

@karato please assign to someone else. no facebook for me, sorry.

@pinaf
Copy link
Contributor

pinaf commented Mar 1, 2015

@karato please assign someone else.

@karato
Copy link

karato commented Mar 2, 2015

@karato please assign someone else.

@pinaf right, I will find someone else, no problem

@karato
Copy link

karato commented Mar 2, 2015

@longtimeago do this task

@karato karato assigned longtimeago and unassigned pinaf Mar 2, 2015
@longtimeago
Copy link
Contributor

@ggajos have you updated task description according to the Yegor's proposal?
Could you please define a use case for the new app? For me, it's not clear at all

Please, define what is the exact problem, how did you end up with this task? And then we decide how to solve the problem

@ggajos
Copy link
Author

ggajos commented Mar 2, 2015

@longtimeago Use case: User should be able to login via Facebook OAuth.

Implementation and design of OAuth will be covered along with #15 but we have to obtain tokens. See https://developers.facebook.com/docs/facebook-login/manually-build-a-login-flow/v2.2. The only way to get those tokens (correct me If I'm wrong) is to create an facebook app. We have to create new facebook app and provide a way to get them in via code.

@longtimeago
Copy link
Contributor

@yegor256 @ggajos Do we really want to create an application for that? Maybe mocks would be enough?
On my opinion, this task is a bit premature. We even don't have an UI endpoints

@ggajos
Copy link
Author

ggajos commented Mar 2, 2015

@longtimeago in some point we have to create app for production; mock might be useful but we need to understand exactly how facebook auth is going to work (settings in web panel etc.); we might even create integration test that will use dev. app; it will be very useful for finalization and preparation of prod. app config on facebook; it's a big task so it's better to start it early, let's focus on creating facebook app and get right security codes.

@yegor256 I think that task is not strictly about programming but bit more about configuration; maybe dev app should be created under proper teamed.io facebook user, it can be used later on as good template for prod. env.?

@yegor256
Copy link
Contributor

yegor256 commented Mar 2, 2015

@k0r could you please help us here. you should go to https://developers.facebook.com and create a new application there (call it "nerodesk"). Then, you will have to create another one (call it "nerodesk-test"), which will be used for testing purposes. Please post us app ID and secret codes for the "nerodesk-test" only.

@ghost
Copy link

ghost commented Mar 3, 2015

@yegor256 responded via email.

@longtimeago
Copy link
Contributor

@yegor256 @ggajos do you still need my help here?
If you have a test app on facebook we don't need to invent something own, right?

@karato
Copy link

karato commented Mar 15, 2015

@karato we're waiting for #77

@krzyk yes, waiting for #77

@yegor256
Copy link
Contributor

@karato assign me to this pls

@yegor256
Copy link
Contributor

@rultor release, tag is 0.1.1

@rultor
Copy link
Contributor

rultor commented Mar 16, 2015

@rultor release, tag is 0.1.1

@yegor256 OK, I will release it now. Please check the progress here

@rultor
Copy link
Contributor

rultor commented Mar 16, 2015

@rultor release, tag is 0.1.1

@yegor256 Oops, I failed. You can see the full log here (spent 20min)

yegor256 pushed a commit that referenced this issue Mar 16, 2015
@yegor256
Copy link
Contributor

@rultor release, tag is 0.1.1

@rultor
Copy link
Contributor

rultor commented Mar 16, 2015

@rultor release, tag is 0.1.1

@yegor256 OK, I will release it now. Please check the progress here

@rultor
Copy link
Contributor

rultor commented Mar 16, 2015

Release 0.1.1 already exists! I can't duplicate it, but I posted a comment there. In the future, try to avoid duplicate releases

@rultor
Copy link
Contributor

rultor commented Mar 16, 2015

@rultor release, tag is 0.1.1

@yegor256 Done! FYI, the full log is here (took me 11min)

yegor256 pushed a commit that referenced this issue Mar 16, 2015
@yegor256
Copy link
Contributor

@rultor release tag is 0.1.2

@rultor
Copy link
Contributor

rultor commented Mar 16, 2015

@rultor release tag is 0.1.2

@yegor256 OK, I will release it now. Please check the progress here

@rultor
Copy link
Contributor

rultor commented Mar 16, 2015

@rultor release tag is 0.1.2

@yegor256 Oops, I failed. You can see the full log here (spent 10min)

yegor256 pushed a commit that referenced this issue Mar 16, 2015
@yegor256
Copy link
Contributor

@rultor release tag is 0.1.2

@rultor
Copy link
Contributor

rultor commented Mar 16, 2015

@rultor release tag is 0.1.2

@yegor256 OK, I will release it now. Please check the progress here

@rultor
Copy link
Contributor

rultor commented Mar 16, 2015

@rultor release tag is 0.1.2

@yegor256 Done! FYI, the full log is here (took me 10min)

@yegor256
Copy link
Contributor

@ggajos I believe this problem is fixed, you can login with Facebook to beta.nerodesk.com

@karato
Copy link

karato commented Mar 17, 2015

@karato assign me to this pls

@yegor256 sure, the ticket is yours, go ahead

@karato karato assigned yegor256 and unassigned krzyk Mar 17, 2015
@karato
Copy link

karato commented Mar 17, 2015

I think we can continue, impediment #77 is closed

@yegor256
Copy link
Contributor

@ggajos see #87 for login issue

@ggajos
Copy link
Author

ggajos commented Mar 17, 2015

@yegor256 ok, let's close this one

@yegor256
Copy link
Contributor

@ggajos it's your ticket, please close it

@ggajos
Copy link
Author

ggajos commented Mar 18, 2015

@yegor256 sorry, thought I did it.

@ggajos ggajos closed this as completed Mar 18, 2015
@karato
Copy link

karato commented Mar 19, 2015

@yegor256 30 mins added to your account (payment number 000-58801d63), many thanks for your contribution!. +30 added to your rating, current score is: +8518

@ghost ghost mentioned this issue Mar 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants