Fix osupdate script broken by #444 #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
librenms#444 broke osupdate script
|
Hello, While I'm unsure this is the right approach to fix this issue, I confirm this patch solves an issue where LibreNMS cannot pull the number of updates properly. @VVelox This would be cool if you could look into it, as in the current state, the osupdate does not work. Cheers! |
|
@JamesMenetrey Sure! Looking. |
|
Confirmed. This only works with the older extend with out that line. The LibreNMS commit in relationship to this only passed as there are no relevant tests to make sure it did not fail. |
|
Added a line to uncomment to use it as a agent. #471 |
3 tasks
|
Many thanks for your quick feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#444 broke osupdate script through snmp extend