New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable secure cookies #6868

Merged
merged 22 commits into from Jun 26, 2017

Conversation

Projects
None yet
6 participants
@rzig
Contributor

rzig commented Jun 20, 2017

This will enable secure cookies automatically over HTTPS and has a line in config.default.php that can be uncommented to enable secure session cookies.

Would you like me to add any documentation on the line in config.default.php?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

fixes: #6866

rzig added some commits Jun 20, 2017

Enable secure cookies for authentication
Enables secure cookies for authentication when HTTPS is used.
@CLAassistant

This comment has been minimized.

Show comment
Hide comment
@CLAassistant

CLAassistant Jun 20, 2017

CLA assistant check
All committers have signed the CLA.

CLAassistant commented Jun 20, 2017

CLA assistant check
All committers have signed the CLA.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jun 20, 2017

Auto-Deploy finished, Test PR at http://6868.ci.librenms.org or https://6868.ci.librenms.org

rzig added some commits Jun 20, 2017

Added secure cookie config to init.php
Commented out because having this enabled will prevent the server from sending cookies over HTTPS.
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jun 20, 2017

Auto-Deploy finished, Test PR at http://6868.ci.librenms.org or https://6868.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jun 20, 2017

Auto-Deploy finished, Test PR at http://6868.ci.librenms.org or https://6868.ci.librenms.org

@rzig

This comment has been minimized.

Show comment
Hide comment
@rzig

rzig Jun 20, 2017

Contributor

@murrant, the Travis CI build failed, but I don't think it is as a result of my code as the lines I added were commented out and the error related to a syslog test that appears to be a result of the previous merge.

Contributor

rzig commented Jun 20, 2017

@murrant, the Travis CI build failed, but I don't think it is as a result of my code as the lines I added were commented out and the error related to a syslog test that appears to be a result of the previous merge.

Show outdated Hide outdated html/includes/authentication/functions.php
Show outdated Hide outdated html/includes/authentication/functions.php
Show outdated Hide outdated includes/init.php
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jun 20, 2017

Auto-Deploy finished, Test PR at http://6868.ci.librenms.org or https://6868.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jun 20, 2017

Auto-Deploy finished, Test PR at http://6868.ci.librenms.org or https://6868.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jun 20, 2017

Auto-Deploy finished, Test PR at http://6868.ci.librenms.org or https://6868.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jun 20, 2017

Auto-Deploy finished, Test PR at http://6868.ci.librenms.org or https://6868.ci.librenms.org

rzig added some commits Jun 20, 2017

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jun 20, 2017

Auto-Deploy finished, Test PR at http://6868.ci.librenms.org or https://6868.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jun 20, 2017

Auto-Deploy finished, Test PR at http://6868.ci.librenms.org or https://6868.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jun 20, 2017

Auto-Deploy finished, Test PR at http://6868.ci.librenms.org or https://6868.ci.librenms.org

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Jun 21, 2017

Member

I've pushed a fix for the travis failures, you'll have to merge it to fix your build failure.

Member

murrant commented Jun 21, 2017

I've pushed a fix for the travis failures, you'll have to merge it to fix your build failure.

rzig added some commits Jun 21, 2017

@rzig rzig referenced this pull request Jun 22, 2017

Closed

Secure cookies not enabled #6866

@rzig

This comment has been minimized.

Show comment
Hide comment
@rzig

rzig Jun 22, 2017

Contributor

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Forgot to include this earlier, sorry.

Contributor

rzig commented Jun 22, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Forgot to include this earlier, sorry.

rzig added some commits Jun 22, 2017

Show outdated Hide outdated config.php.default
@rzig

This comment has been minimized.

Show comment
Hide comment
@rzig

rzig Jun 23, 2017

Contributor

There's a bit of an issue. When I try and apply the patch it says error: patch failed: includes/process_config.inc.php:36. I'm thinking it has something to do with whitespace, but I don't see anything out of the ordinary. Any ideas?

Contributor

rzig commented Jun 23, 2017

There's a bit of an issue. When I try and apply the patch it says error: patch failed: includes/process_config.inc.php:36. I'm thinking it has something to do with whitespace, but I don't see anything out of the ordinary. Any ideas?

rzig added some commits Jun 23, 2017

@rzig

This comment has been minimized.

Show comment
Hide comment
@rzig

rzig Jun 23, 2017

Contributor

The git issue is fixed - it still complains about whitespace, but it applies the patches.

Contributor

rzig commented Jun 23, 2017

The git issue is fixed - it still complains about whitespace, but it applies the patches.

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Jun 23, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Jun 23, 2017

The inspection completed: No new issues

@laf

laf approved these changes Jun 23, 2017

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jun 23, 2017

Member

LGTM

Member

laf commented Jun 23, 2017

LGTM

@laf laf merged commit 1ba6381 into librenms:master Jun 26, 2017

2 of 3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.