Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config class collides with Config in model namespace #9249

Merged
merged 1 commit into from
Sep 21, 2018

Conversation

murrant
Copy link
Member

@murrant murrant commented Sep 21, 2018

This causes a fatal error on php 5.6 in the ospf module. (which stops poller of course)

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Copy link
Contributor

@TheGreatDoc TheGreatDoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheGreatDoc TheGreatDoc merged commit 4e9a036 into librenms:master Sep 21, 2018
@laf laf deleted the ns-collision branch September 21, 2018 17:13
@lock lock bot locked as resolved and limited conversation to collaborators Nov 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants