Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod support? #17

Closed
diamondburned opened this issue Apr 19, 2019 · 5 comments
Closed

go.mod support? #17

diamondburned opened this issue Apr 19, 2019 · 5 comments

Comments

@diamondburned
Copy link
Contributor

I'm forking my own to add go.mod support, but if the maintainer is still alive, please reply to this, so I could promptly make a PR.

@xplodwild
Copy link
Contributor

I'm still alive, if you make a PR for this I'd be more than happy to merge it

@diamondburned
Copy link
Contributor Author

Does this package structure look ok? I changed it from the old src/ structure of Rust's.

Importing goes

import (
	"github.com/diamondburned/librespot-golang/librespot"
	"github.com/diamondburned/librespot-golang/librespot/core"
)

@xplodwild
Copy link
Contributor

Looks good to me!

@diamondburned
Copy link
Contributor Author

Opened a PR: #18

@xplodwild
Copy link
Contributor

Merged PR, so closing this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants