Add OAuth token authentication #436
Conversation
… spotify-token authentication
dhenneke
changed the title
| @@ -114,6 +114,7 @@ fn setup(args: &[String]) -> Setup { | |||
| .optflag("v", "verbose", "Enable verbose output") | |||
| .optopt("u", "username", "Username to sign in with", "USERNAME") | |||
| .optopt("p", "password", "Password", "PASSWORD") | |||
| .optopt("t", "token", "Spotify OAuth token with scope 'streaming'. Use 'user' as username.", "TOKEN") | |||
There was a problem hiding this comment.
I'm not sure this feature warrants a shorthand option.
| @@ -24,6 +24,8 @@ enum AuthenticationType { | |||
| AUTHENTICATION_STORED_FACEBOOK_CREDENTIALS = 0x2; | |||
| AUTHENTICATION_SPOTIFY_TOKEN = 0x3; | |||
| AUTHENTICATION_FACEBOOK_TOKEN = 0x4; | |||
| // this type is returned when requesting AUTHENTICATION_SPOTIFY_TOKEN | |||
| AUTHENTICATION_UNKNOWN = 0x7; | |||
There was a problem hiding this comment.
Have you had a look at the proto definitions from the official client to see if there is an actual definition for the 0x7 response? I'm hesitant to just slap an unknown definition in, as it is messy and not very readable/maintainable long term if they start to stack up. I know we have (had) a couple in the library, but we generally try to replace them with the actual value from the client once it is available.
There was a problem hiding this comment.
Where can I find the official definitions? I was not aware that they are public.
There was a problem hiding this comment.
@sashahilton00 I think that those definition files cannot be extracted from the client anymore for some reason. They don't appear when dumping with HearthSim/proto-extractor.
There was a problem hiding this comment.
I believe it should be along these lines - dumped from the client strings.
Also to note, I no longer see the kAuthenticationType mentioned anywhere, and only kAuthenticationTypeCount
credentials.auth_type() < auth::kAuthenticationTypeCount:
obfuscatedSecret
password
blobBase64
autologin
storedSpotifyCredentials
storedFacebookCredentials
spotifyToken
facebookToken
anonymousAccount
storedAnonymousCredentials
storedSpotifyRefreshToken
spotifyPassword
phoneNumber
oneTimeToken
|
FYI, I tried to implement this in librespot-java with the new protocol and it cannot work because the subsystem needs to create tokens on its own: the server keeps responding with 403 because it hasn't sufficient permission. |
|
@devgianlu are you saying that you can't use an oauth token with librespot even if it's requested with the streaming scope? I'm assuming there are issues with it being tied to a client_id... |
|
We are using this patch for over two years now and it works flawlessly. We use it for an internal music bot where you log in to a website to start playback. A tool receives a token from the oauth flow and starts librespot with it. The tool uses the token to get the currently playing song and displays it in the website. Playback is controlled by the Spotify app itself where you can select the bot as playback device. I don’t know whether librespot also uses this token to get details about the playback or to control playback. We do this in our tool by calling the Spotify api where. There we also have a refresh token to rotate it automatically whenever it expires. But the initial librespot sessions stays open. |
Yeah, it's probably because of the client_id used. I am not able to request any token at all if authenticating with a token (which makes sense). Problem is that a token is needed to start the websocket connection |
If you're controlling playback using the Spotify app, why would you even need to authenticate librespot beforehand? I'm a bit confused as I'm doing the exact opposite: I'm using librespot to authenticate using the Spotify app, then get the token from librespot to use in my web app... Because authentication using the app is a no brainer and comes for free, where as implementing oauth is a lot of effort... |
|
We are using librespot as playback device and since we use it with multiple accounts we don’t want to know the Spotify account password of the user but use a token that was received via oauth where the user logged in to the official Spotify website |
But that's the point: you don't need to authenticate librespot itself. The Spotify app will do this for you! I simply run librespot only giving it a name and a cache folder where there was nothing before. Then I selected it in the Spotify app: After that there would be a file called |
|
But librespot is running in a docker Container on our server where no one has a network connection to, so the Spotify app can‘t discover it and log in. We use it the other way around that librespot logs in the account so that is registered and available in all Spotify apps of the User from the internet |
|
I might be wrong, but it looks as if you need to run a patched librespot in docker in order to have it configured by some authentication application which wouldn't be required in the first place if you run librespot on its own? This is not my project, thus my opinion doesn't count at all. But this sounds like adding complexity to the application to make an overly complicated setup work. Just run librespot and you won't need docker nor an additional application to sign in. |
|
I’m with @michaelherger here. This functionality at a push might go in the daemon, but in general I don’t think we should add in this functionality as it’s not available on any of the official clients, @devgianlu mentioned that there are possible permission errors, and it feels like this is a workaround for an abnormal setup, in which case it would be more appropriate for OP to maintain a patch. If no one objects I think we can close this as wontfix? |
|
Thanks for your feedback. I didn't know our setup is so unusual. I'm also fine with maintaining a fork. |
This PR adds an option to login with an Spotify OAuth token. Get a token and request the streaming scope.
Start with:
librespot --username user --token YOUR_OAUTH_TOKENWhen I use
AuthenticationType::AUTHENTICATION_SPOTIFY_TOKENas authType, the API for some reason replies with an Authentication Type of0x7. Since I don't know what this value means originally, I just added a placeholder type to the proto file.