Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mismatched reference counting in SSL_new() #51

Closed
Parakleta opened this issue Oct 2, 2015 · 1 comment
Closed

Mismatched reference counting in SSL_new() #51

Parakleta opened this issue Oct 2, 2015 · 1 comment

Comments

@Parakleta
Copy link

Found this while reading the code, not through testing. The reference count on the ctx structure is incremented for the assignment of ctx to s->initial_ctx but this is not decremented on the code path through the err: label. The increment/decrement is matched for the assignment of ctx to s->ctx.

ssl_lib.c.
@hogand
Copy link

hogand commented Oct 3, 2015

Thanks! Fixed in -current.

@hogand hogand closed this as completed Oct 3, 2015
busterb pushed a commit that referenced this issue Oct 6, 2015
SSL_new(): fix ref counting and memory leak in error path.
c81daac 
Rather than a half-hearted attempt to free up resources and fix
ref counting at the SSL_CTX level, let SSL_free() do its job.

This diff got lost in the shuffle somewhere.  It's from last year.
Ref counting error reported by Parakleta in github ticket #51.  Thanks!

ok jsing@, beck@
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hogand @Parakleta