Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copy/paste error when mapping the new buttons for P2. #74

Merged
merged 2 commits into from
Feb 11, 2022

Conversation

msheehan79
Copy link
Contributor

Move R3 to its proper index for P2.

@BlazeEntertainment
Copy link

This is now OOB and will Seg fault if you load the core.

Update the sizes to something like:

int joypad0[20]; // joypad 0 state
int joypad1[20]; // joypad 1 state
int joypre0[20]; // joypad 0 previous state
int joypre1[20]; // joypad 1 previous state

To resolve the OOB and then it should fix the problem

@msheehan79
Copy link
Contributor Author

Thanks @BlazeEntertainment for the catch. Will update this PR this evening to include this.

…ount for the additional buttons in the previous state copy loop.
@cmitu
Copy link

cmitu commented Feb 11, 2022

@twinaphex any chance of merging this PR ? It would fix the core segfault/crash and make the core usable again.
Thank you.

@inactive123 inactive123 merged commit 3f5e032 into libretro:master Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants