Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for "no sound on PS2" #15827

Merged
merged 1 commit into from Oct 24, 2023
Merged

Conversation

zoltanvb
Copy link
Contributor

Description

Earlier refactor f121847 has removed CMD_EVENT_AUDIO_START (and stop), however on PS2 it causes no sound, so it is added back behind a compiler switch.
Ideally, PS2 sound driver would also need no special treatment, but my attempts at having the audio driver running by default, or initializing it from ps2_init in ps2_gfx.c, just resulted in freezes.

Related Issues

Closes #15759 #15655

Related Pull Requests

#15523

Earlier refactor libretro@f121847
has removed CMD_EVENT_AUDIO_START (and stop), however on PS2 it
causes no sound, so it is added back behind a compiler switch.
@LibretroAdmin LibretroAdmin merged commit 57e9a3e into libretro:master Oct 24, 2023
22 checks passed
@sonninnos
Copy link
Collaborator

sonninnos commented Oct 24, 2023

Hmm, since it does not take settings->bools.audio_enable_menu into account, won't stopping it always on menu toggle also prevent menu sounds from working completely..? PS2 build does have HAVE_AUDIOMIXER enabled, which is required for menu sounds.

Pretty weird that audio is not started anywhere else than menu toggle then, and only when menu is pausing..

@zoltanvb
Copy link
Contributor Author

zoltanvb commented Oct 24, 2023

It does prevent it, but I tend to say that menu sounds have never worked on PS2. Tested now with 1.9.0, same result, no sound in menu.

@sonninnos
Copy link
Collaborator

Weird. And the sound assets are included?

@zoltanvb
Copy link
Contributor Author

Fair point, they are not. But I added them to my install, still the only difference I could achieve was that sound was gone from the games as well. And if I remove the audio stop part, last buffer contents will play looped while in menu, which does not provide a nice experience.

@sonninnos
Copy link
Collaborator

Ok, good as long as it does not crash when it stops audio while menu sounds are enabled. Something is indeed seriously wrong if that audio starting is required for cores..

JoeOsborn pushed a commit to JoeOsborn/RetroArch that referenced this pull request Nov 2, 2023
Earlier refactor libretro@f121847
has removed CMD_EVENT_AUDIO_START (and stop), however on PS2 it
causes no sound, so it is added back behind a compiler switch.
@BostonTodd
Copy link

I just downloaded and installed the latest version of Retroarch for PS2 today and have not been able to get sound on any ROM so far. Also no sound in the Retroarch menus. Total newbie to this... Please let me know how to apply the fix. Thanks in advance!

@zoltanvb
Copy link
Contributor Author

The latest stable version has been 1.16.0 which still has this problem. Try the newer, nightly builds at:
http://buildbot.libretro.com/nightly/playstation/ps2/
Menu sounds will not work unfortunately.

@BostonTodd
Copy link

The latest stable version has been 1.16.0 which still has this problem. Try the newer, nightly builds at: http://buildbot.libretro.com/nightly/playstation/ps2/ Menu sounds will not work unfortunately.

Thanks...I will l give that a try!

@zoltanvb zoltanvb deleted the fix_ps2_no_sound branch December 1, 2023 20:22
@joe-devola
Copy link

hi Jerry. Any update on a fix with this problem? Or has anyone had any luck with the nightly builds?

@joe-devola
Copy link

Just gave it a shot. The most recent nightly build has audio! Thanks for the suggestion! You F'n rock my dudes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retroarch Playstation no Sound
5 participants