Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update core to 1.23.0 #45

Closed
ToniBC opened this issue Sep 5, 2019 · 2 comments
Closed

Update core to 1.23.0 #45

ToniBC opened this issue Sep 5, 2019 · 2 comments

Comments

@ToniBC
Copy link

ToniBC commented Sep 5, 2019

Mednafen was recently updated with several corrections of this emulator and it would be nice to include them to improve those small errors. I don't know if some have already been applied, but since the core only reflects that it is in 0.9.36.1, they supposedly were not added.

After 0.9.36.1 there are several changes that would be good to include in the core to improve emulation.

  • VB: Made (better) use of exceptions in the ROM image loading and initialization code.
  • VB: Corrected the value that the timer reload register is initialized with on reset.
  • VB: Migrated debugger functions VBDBG_GetRegister() and VBDBG_SetRegister() over to the newer-style interface that takes integer IDs instead of std::string.
  • VB: Replaced endian-handling functions local to vip.cpp with new code in endian.h derived from code written for Saturn emulation.
  • VB: Fixed a regression introduced in 0.9.39.2 that caused transient sound/note distortion on save state load.
  • VB: Finally commented out some debug printf()s.
  • VB: Added support for custom palettes.
  • VB: Reworked how LED on-state duration is translated into RGB values and added setting "vb.ledonscale"; the default value of "vb.ledonscale" is set such that the overall brightness will be lower than in previous versions of Mednafen, to reduce white crush, but the user can set it to a value of "1.9921875" to approximate the old brightness level.
  • VB: Added the ability to toggle the state of the low battery sensor bit; configure the device on virtual input port 2(e.g. ALT+SHIFT+2) to assign a key/button to this function.

I comment as you recommended to me to be reflected and appear as a pending task.

Many thanks for your work.

@ghost
Copy link

ghost commented Nov 11, 2019

There was enough stuff missing here also.
#47

This is a full update.

@ToniBC
Copy link
Author

ToniBC commented Nov 15, 2019

Thank you very much for updating it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant