Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LWS-159: Run Lighthouse tests on CI #1070

Merged
merged 25 commits into from
Aug 29, 2024

Conversation

johanbissemattsson
Copy link
Contributor

@johanbissemattsson johanbissemattsson commented Jun 14, 2024

Description

Tickets involved

LWS-159

Solves

Runs Lighthouse tests continuously using lighthouse-ci in a GitHub action.

The github action status currently only shows if the tests fails or passes.
We have to self-host a Lighthouse CI server if we want more detailed metrics in the status check.

The Lighthouse CI server can also be used for:

  • Store Lighthouse reports for more than a few days
  • Keep Lighthouse reports private on your infrastructure
  • Generate graphs of improved category scores over time to impress your boss
  • Identify regressions in category score or metric performance to specific commits
  • View detailed diffs between any two Lighthouse reports to find the root cause of a regression

Summary of changes

  • Rename github workflow file
  • Format workflow file
  • Add lighthouse-ci to github workflow

@johanbissemattsson johanbissemattsson changed the title Feature/lws 159 run lighthouse tests on ci LWS-159: Run Lighthouse tests on CI Jun 14, 2024
@johanbissemattsson johanbissemattsson marked this pull request as ready for review June 17, 2024 12:17
@johanbissemattsson johanbissemattsson force-pushed the feature/LWS-159-run-lighthouse-tests-on-ci branch from 3d090d9 to 610b203 Compare June 18, 2024 07:34
@johanbissemattsson
Copy link
Contributor Author

johanbissemattsson commented Jun 18, 2024

Note to self:
We have to add a LHCI_TOKEN to .github/workflows/lxl-web.yml if we decide to self-host a Lighthouse CI server.

See: https://github.com/GoogleChrome/lighthouse-ci/blob/main/docs/getting-started.md#configuration

Copy link
Member

@andersju andersju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM!

@johanbissemattsson johanbissemattsson merged commit 5b872ec into develop Aug 29, 2024
2 checks passed
@johanbissemattsson johanbissemattsson deleted the feature/LWS-159-run-lighthouse-tests-on-ci branch August 29, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants