Skip to content
Permalink
Browse files

Fixed buildbot's static analysis script to enable assertions.

This removes false positives. Apparently someone forced the default CMake
builds to use -O3, turning these off by default.  :/
  • Loading branch information
icculus committed Jan 8, 2016
1 parent ed62033 commit 06129f6de95fb1d7594bc0c45a53bb64ef48259c
Showing with 3 additions and 3 deletions.
  1. +3 −3 build-scripts/checker-buildbot.sh
@@ -61,13 +61,13 @@ mkdir checker-buildbot
cd checker-buildbot

# You might want to do this for CMake-backed builds instead...
PATH="$CHECKERDIR:$PATH" scan-build -o analysis cmake -DCMAKE_BUILD_TYPE=Debug ..
PATH="$CHECKERDIR:$PATH" scan-build -o analysis cmake -DCMAKE_BUILD_TYPE=Debug -DASSERTIONS=enabled ..

# ...or run configure without the scan-build wrapper...
#CC="$CHECKERDIR/libexec/ccc-analyzer" CFLAGS="-O0" ../configure
#CC="$CHECKERDIR/libexec/ccc-analyzer" CFLAGS="-O0" ../configure --enable-assertions=enabled

# ...but this works for our buildbots just fine (EXCEPT ON LATEST MAC OS X).
#CFLAGS="-O0" PATH="$CHECKERDIR:$PATH" scan-build -o analysis ../configure
#CFLAGS="-O0" PATH="$CHECKERDIR:$PATH" scan-build -o analysis ../configure --enable-assertions=enabled

rm -rf analysis
PATH="$CHECKERDIR:$PATH" scan-build -o analysis $MAKE

0 comments on commit 06129f6

Please sign in to comment.