Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autoreconf in test/ directory fails with autoconf 2.71 #4719

Closed
smcv opened this issue Sep 6, 2021 · 0 comments · Fixed by #4720
Closed

autoreconf in test/ directory fails with autoconf 2.71 #4719

smcv opened this issue Sep 6, 2021 · 0 comments · Fixed by #4720

Comments

@smcv
Copy link
Contributor

smcv commented Sep 6, 2021

To reproduce:

  • Have autoconf 2.71 or later
  • cd test/
  • autoreconf -fi

Expected result: configure is regenerated

Actual result:

$ autoreconf -fi
acinclude.m4:182: warning: the serial number must appear before any macro definition
autoreconf: error: cannot create $srcdir/../build-scripts: No such file or directory
Error in tempfile() using template $srcdir/../build-scripts/XXXXXXXXXX: Parent directory ($srcdir/../build-scripts/) does not exist at /usr/bin/autoreconf line 403.

I'll send a merge request.
smcv added a commit to smcv/SDL that referenced this issue Sep 6, 2021
@smcv
test: Fix path used in AC_CONFIG_AUX_DIR
1bc26a9 
AC_CONFIG_AUX_DIRS is an undocumented, internal version of
AC_CONFIG_AUX_DIR that takes a whitespace-separated list, instead of a
single path to add to the list. Use the documented version instead, as
in the top-level configure.ac.

Newer versions of autoconf treat the argument to AC_CONFIG_AUX_DIRS
as being literal (they do not expand the shell variable), causing
autoreconf to fail. The argument to AC_CONFIG_AUX_DIR is documented
to be relative to $srcdir anyway, so there is no need to specify $srcdir
a second time.

Resolves: libsdl-org#4719
Signed-off-by: Simon McVittie <smcv@debian.org>
@smcv smcv mentioned this issue Sep 6, 2021
Merged
smcv added a commit to smcv/SDL that referenced this issue Sep 6, 2021
@smcv
test: Fix path used in AC_CONFIG_AUX_DIR
0b18fd2 
AC_CONFIG_AUX_DIRS is an undocumented, internal version of
AC_CONFIG_AUX_DIR that takes a whitespace-separated list, instead of a
single path to add to the list. It also does not automatically treat
the given path as being relative to the $srcdir, unlike the documented
AC_CONFIG_AUX_DIR.

Newer versions of autoconf treat the argument to AC_CONFIG_AUX_DIRS
as being literal (they do not expand the shell variable), causing
autoreconf to fail if $srcdir is explicitly specified. The argument to
AC_CONFIG_AUX_DIR is checked  relative to $srcdir anyway, so there is no
need to specify $srcdir a second time.

Resolves: libsdl-org#4719
Signed-off-by: Simon McVittie <smcv@debian.org>
sezero pushed a commit that referenced this issue Sep 6, 2021
@smcv @sezero
test: Fix path used in AC_CONFIG_AUX_DIR
91ce601 
AC_CONFIG_AUX_DIRS is an undocumented, internal version of
AC_CONFIG_AUX_DIR that takes a whitespace-separated list, instead of a
single path to add to the list. It also does not automatically treat
the given path as being relative to the $srcdir, unlike the documented
AC_CONFIG_AUX_DIR.

Newer versions of autoconf treat the argument to AC_CONFIG_AUX_DIRS
as being literal (they do not expand the shell variable), causing
autoreconf to fail if $srcdir is explicitly specified. The argument to
AC_CONFIG_AUX_DIR is checked  relative to $srcdir anyway, so there is no
need to specify $srcdir a second time.

Resolves: #4719
Signed-off-by: Simon McVittie <smcv@debian.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: Fix path used in AC_CONFIG_AUX_DIR smcv/SDL
1 participant
@smcv