Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing quotes in the fallback CHECK_OBJC_SOURCE_COMPILES macro? #6268

Closed
sezero opened this issue Sep 21, 2022 · 2 comments
Closed

missing quotes in the fallback CHECK_OBJC_SOURCE_COMPILES macro? #6268

sezero opened this issue Sep 21, 2022 · 2 comments

Comments

@sezero
Copy link
Contributor

sezero commented Sep 21, 2022

@madebr: is the following correct? Without it, my cmake-3.9.6 errored out with
e.g. Unknown argument: HAVE_FRAMEWORK_GAMECONTROLLER

diff --git a/cmake/macros.cmake b/cmake/macros.cmake
index 62621dd..f282438 100644
--- a/cmake/macros.cmake
+++ b/cmake/macros.cmake
@@ -96,7 +96,7 @@ if(${CMAKE_VERSION} VERSION_LESS "3.16.0")
   macro(CHECK_OBJC_SOURCE_COMPILES SOURCE VAR)
     set(PREV_REQUIRED_DEFS "${CMAKE_REQUIRED_DEFINITIONS}")
     set(CMAKE_REQUIRED_DEFINITIONS "-x objective-c ${PREV_REQUIRED_DEFS}")
-    CHECK_C_SOURCE_COMPILES(${SOURCE} ${VAR})
+    CHECK_C_SOURCE_COMPILES("${SOURCE}" ${VAR})
     set(CMAKE_REQUIRED_DEFINITIONS "${PREV_REQUIRED_DEFS}")
   endmacro()
 else()
@madebr
Copy link
Contributor

madebr commented Sep 21, 2022

Looks okay. Does your path contain spaces?

@sezero
Copy link
Contributor Author

sezero commented Sep 21, 2022

Look okay.

OK, pushing shortly.

Does your path contain spaces?

No, it does not.

sezero added a commit that referenced this issue Sep 21, 2022
@sezero sezero closed this as completed in 098a7a0 Sep 21, 2022
sezero added a commit to sezero/SDL that referenced this issue Sep 21, 2022
PJB3005 pushed a commit to PJB3005/SDL that referenced this issue Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants